Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for Julia v1.8.x #252

Merged
merged 6 commits into from
Sep 30, 2022
Merged

Backports for Julia v1.8.x #252

merged 6 commits into from
Sep 30, 2022

Conversation

rayegun
Copy link
Member

@rayegun rayegun commented Sep 8, 2022

Co-authored-by: Steven G. Johnson stevenj@mit.edu

Note: I want to be sure the attribution is correct here, I think it should say "authored by Jerry and Steven" and "committed by Wimmerer".

Backported PRs:

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
@dkarrasch
Copy link
Member

x-ref #245 (I followed the instructions literally in the backport action error message, so it has slightly different source and target branches).

@rayegun
Copy link
Member Author

rayegun commented Sep 8, 2022

Did that one pass tests? I'm not sure what the issue is with this one, maybe I didn't do it right. I just followed #249 without realizing you had already done the backport. We should collect #93 and #253 on a single release-1.8 branch at some point before adjusting julialang/julia according to #249.

@dkarrasch dkarrasch closed this Sep 13, 2022
@dkarrasch dkarrasch reopened this Sep 13, 2022
@dkarrasch dkarrasch changed the title Backport fix findmin/findmax (#93) Backports for Julia v1.8.x Sep 13, 2022
@KristofferC
Copy link
Member

Note: I want to be sure the attribution is correct here, I think it should say "authored by Jerry and Steven" and "committed by Wimmerer".

Do you do git cherry-pick -x COMMIT?

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #252 (f7dc713) into release-1.8 (aa51c9b) will decrease coverage by 0.11%.
The diff coverage is 86.95%.

@@               Coverage Diff               @@
##           release-1.8     #252      +/-   ##
===============================================
- Coverage        89.16%   89.05%   -0.12%     
===============================================
  Files                7        7              
  Lines             5667     5673       +6     
===============================================
- Hits              5053     5052       -1     
- Misses             614      621       +7     
Impacted Files Coverage Δ
src/SparseArrays.jl 100.00% <ø> (ø)
src/sparsevector.jl 94.19% <84.21%> (+0.02%) ⬆️
src/sparsematrix.jl 94.74% <100.00%> (-0.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rayegun
Copy link
Member Author

rayegun commented Sep 14, 2022

Yes iirc

@rayegun
Copy link
Member Author

rayegun commented Sep 15, 2022

@dkarrasch we just need the circshift changes here right? Then we're good to merge?

(cherry picked from commit 4fb8f0e)
@fredrikekre fredrikekre marked this pull request as ready for review September 16, 2022 10:02
@dkarrasch
Copy link
Member

It turns out we also have #176 labelled for backport.

@KristofferC
Copy link
Member

Please push an update to JuliaLang/julia#46663 when this is done.

@rayegun
Copy link
Member Author

rayegun commented Sep 16, 2022

I only know how this works with BumpStdlibs.jl, is that used here?

@dkarrasch
Copy link
Member

I guess now we should wait for the clean-up PR for circshift, right? Otherwise, I don't see anything on the horizon that needs action.

@rayegun
Copy link
Member Author

rayegun commented Sep 19, 2022

circshift and I need to fix two typos I found. Then we're good.

@dkarrasch
Copy link
Member

The release of v1.8.2 has been announced, and we really should get the backports in. Do we need to include anything else? Or shall we merge this and go ahead on the Julia Base side?

@rayegun
Copy link
Member Author

rayegun commented Sep 27, 2022

I think this is ready to go @dkarrasch

@KristofferC
Copy link
Member

I'm gonna merge this now so that it doesn't miss 1.8.3 as well.

@KristofferC KristofferC merged commit 1d3ec86 into release-1.8 Sep 30, 2022
@KristofferC KristofferC deleted the backports-release-1.8 branch September 30, 2022 13:36
@dkarrasch dkarrasch restored the backports-release-1.8 branch November 24, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants